From e7adf0330665bb439b4147438aa062ffc2d98853 Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Mon, 3 Apr 2023 08:55:18 +0000 Subject: [PATCH 1/2] Do not fail build on incorrect Go version Signed-off-by: Florent Poinsard --- build.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.env b/build.env index 01a37556230..f20583db5e4 100755 --- a/build.env +++ b/build.env @@ -17,7 +17,7 @@ source ./tools/shell_functions.inc go version >/dev/null 2>&1 || fail "Go is not installed or is not in \$PATH. See https://vitess.io/contributing/build-from-source for install instructions." -goversion_min 1.20.2 || fail "Go version reported: `go version`. Version 1.20.2+ required. See https://vitess.io/contributing/build-from-source for install instructions." +goversion_min 1.20.2 || echo "Go version reported: `go version`. Version 1.20.2+ required. See https://vitess.io/contributing/build-from-source for install instructions." mkdir -p dist mkdir -p bin From 7b9244e35c01fb6afefc0c452b540e1fc01a80d2 Mon Sep 17 00:00:00 2001 From: Florent Poinsard Date: Wed, 5 Apr 2023 19:08:57 +0200 Subject: [PATCH 2/2] Remove misleading message in build.env Signed-off-by: Florent Poinsard --- build.env | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.env b/build.env index f20583db5e4..c3cdfbeed29 100755 --- a/build.env +++ b/build.env @@ -17,7 +17,7 @@ source ./tools/shell_functions.inc go version >/dev/null 2>&1 || fail "Go is not installed or is not in \$PATH. See https://vitess.io/contributing/build-from-source for install instructions." -goversion_min 1.20.2 || echo "Go version reported: `go version`. Version 1.20.2+ required. See https://vitess.io/contributing/build-from-source for install instructions." +goversion_min 1.20.2 || echo "Go version reported: `go version`. Version 1.20.2+ recommended. See https://vitess.io/contributing/build-from-source for install instructions." mkdir -p dist mkdir -p bin