Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Cast expression translation by evaluation engine #12111

Merged
merged 1 commit into from
Jan 17, 2023
Merged

BugFix: Cast expression translation by evaluation engine #12111

merged 1 commit into from
Jan 17, 2023

Conversation

GuptaManan100
Copy link
Member

Description

This PR fixes the bug described in #12110. The issue is that the evalengine converts the expression into a eval engine expression whose evaluation isn't supported at runtime. What this means is that planning phase succeeds but the runtime throws an error.
This isn't correct since we have an alternate way of planning of not using the evaluation engine and send the query to a vttablet like we did before evalengine existed.

This PR fixes this bug by failing the translation itself instead of creating an expression that can't be evaluated.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 17, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 17, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

harshit-gangal
harshit-gangal reviewed Jan 17, 2023
View reviewed changes
go/vt/vtgate/evalengine/convert.go
throwEvalError(c.returnUnsupportedError())
}

func (c *ConvertExpr) returnUnsupportedError() error {
var err error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: err variable can be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need it. We write to it in the switch case. Otherwise we would need to return in each switch case. I don't hate that either.

@GuptaManan100
Copy link
Member Author

This is also a regression. It works for release-13.0 but not for 14, 15 and main.

@GuptaManan100 GuptaManan100 added Backport to: release-14.0 and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 17, 2023
@frouioui frouioui merged commit 3a4e9cc into vitessio:main Jan 17, 2023
@frouioui frouioui deleted the cast-date-fix branch January 17, 2023 16:21
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 17, 2023

I was unable to backport this Pull Request to the following branches: release-14.0, release-15.0.

GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Jan 18, 2023
@GuptaManan100
feat: fix translation logic to fail translation for conversions not s…
4127c2f 
…upported (vitessio#12111)

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>
@GuptaManan100 GuptaManan100 mentioned this pull request Jan 18, 2023
Merged
GuptaManan100 added a commit to planetscale/vitess that referenced this pull request Jan 18, 2023
@GuptaManan100
feat: fix translation logic to fail translation for conversions not s…
ef3efd2 
…upported (vitessio#12111)

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>
@GuptaManan100 GuptaManan100 mentioned this pull request Jan 18, 2023
Merged
harshit-gangal pushed a commit that referenced this pull request Jan 19, 2023
@GuptaManan100
feat: fix translation logic to fail translation for conversions not s…
b9fd93e 
…upported (#12111) (#12118)

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>
harshit-gangal pushed a commit that referenced this pull request Jan 19, 2023
@GuptaManan100
feat: fix translation logic to fail translation for conversions not s…
e259218 
…upported (#12111) (#12117)

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>
dbussink pushed a commit that referenced this pull request Jan 30, 2023
@GuptaManan100
feat: fix translation logic to fail translation for conversions not s…
48d0294 
…upported (#12111) (#1500)

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>

Signed-off-by: Manan Gupta <[email protected]>
@austenLacy austenLacy mentioned this pull request Apr 26, 2023
Merged
@austenLacy austenLacy mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: Cast expression query fails but works with a limit clause
3 participants
@GuptaManan100 @harshit-gangal @frouioui