Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dead Legacy Workflow Manager Code #12085

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Jan 12, 2023

Description

The legacy sharding code was removed in v15, but this old workflow management code is even older than the legacy sharding code. It did not work and was dead code, so is being removed here in v16.

Related Issue(s)

Checklist

This was pre-Legacy sharding, which was in turn pre-VReplication.

Signed-off-by: Matt Lord <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 12, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 12, 2023
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord changed the title Remove Dead Legacy Workflow Management Code Remove Dead Legacy Workflow Manager Code Jan 12, 2023
@mattlord mattlord added Component: CLI and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Jan 12, 2023
@deepthi deepthi added release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) and removed Component: CLI labels Jan 12, 2023
@mattlord mattlord removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Jan 12, 2023
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattlord mattlord merged commit f5a999b into vitessio:main Jan 13, 2023
@mattlord mattlord deleted the rm_dead_workflow branch January 13, 2023 17:40
@GuptaManan100
Copy link
Member

GuptaManan100 commented Jan 16, 2023

Folks, we missed the part that when we delete flags, we've to check if VTop is also using them. If it is, then we delete the usage there too. That's the last item in backward compatibility subsection of checklist.
I traced this from the failure in planetscale/vitess-operator#359

@GuptaManan100
Copy link
Member

Here is the fix for VTop - planetscale/vitess-operator#360

@GuptaManan100
Copy link
Member

This PR fixes release-15.0 too, so that upgrade-downgrade tests start working again - #12128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants