-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Dead Legacy Workflow Manager Code #12085
Conversation
This was pre-Legacy sharding, which was in turn pre-VReplication. Signed-off-by: Matt Lord <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Folks, we missed the part that when we delete flags, we've to check if VTop is also using them. If it is, then we delete the usage there too. That's the last item in backward compatibility subsection of checklist. |
Here is the fix for VTop - planetscale/vitess-operator#360 |
This PR fixes release-15.0 too, so that upgrade-downgrade tests start working again - #12128 |
Description
The legacy sharding code was removed in v15, but this old workflow management code is even older than the legacy sharding code. It did not work and was dead code, so is being removed here in v16.
Related Issue(s)
Checklist