-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cherry-pick]Adding deprecate message to backup hooks (#11491) #11587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding deprecate message to backup hooks Signed-off-by: Rameez Sajwani <[email protected]> * adding markdeprecated Signed-off-by: Rameez Sajwani <[email protected]> * fixing deprecation message Signed-off-by: Rameez Sajwani <[email protected]> * fixing messaging Signed-off-by: Rameez Sajwani <[email protected]> * fix flag name Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Rameez Sajwani <[email protected]> Signed-off-by: Manan Gupta <[email protected]> Co-authored-by: Manan Gupta <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
If a new flag is being introduced:
If a workflow is added or modified:
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
rsajwani
changed the title
Adding deprecate message to backup hooks (#11491)
[cherry-pick]Adding deprecate message to backup hooks (#11491)
Oct 26, 2022
rsajwani
added
Component: General
Changes throughout the code base
Type: Bug
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
and removed
Type: Bug
labels
Oct 27, 2022
rsajwani
requested review from
deepthi,
shlomi-noach,
rohit-nayak-ps and
mattlord
as code owners
October 27, 2022 20:41
ajm188
reviewed
Oct 27, 2022
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Rameez Sajwani <[email protected]>
frouioui
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: General
Changes throughout the code base
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cherry-pick #11491
Related Issue(s)
Checklist
Deployment Notes