Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]Adding deprecate message to backup hooks (#11491) #11587

Merged
merged 5 commits into from
Oct 28, 2022

Conversation

rsajwani
Copy link
Contributor

Description

Cherry-pick #11491

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

* Adding deprecate message to backup hooks

Signed-off-by: Rameez Sajwani <[email protected]>

* adding markdeprecated

Signed-off-by: Rameez Sajwani <[email protected]>

* fixing deprecation message

Signed-off-by: Rameez Sajwani <[email protected]>

* fixing messaging

Signed-off-by: Rameez Sajwani <[email protected]>

* fix flag name

Signed-off-by: Rameez Sajwani <[email protected]>

Signed-off-by: Rameez Sajwani <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 26, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@rsajwani rsajwani changed the title Adding deprecate message to backup hooks (#11491) [cherry-pick]Adding deprecate message to backup hooks (#11491) Oct 26, 2022
@rsajwani rsajwani self-assigned this Oct 27, 2022
@rsajwani rsajwani added Component: General Changes throughout the code base Type: Bug Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Type: Bug labels Oct 27, 2022
@rsajwani rsajwani marked this pull request as ready for review October 27, 2022 20:41
@frouioui frouioui merged commit 8aebb6f into vitessio:main Oct 28, 2022
@frouioui frouioui deleted the cherrypick-11491 branch October 28, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: General Changes throughout the code base Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants