Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please ensure make only builds binaries and does not run the test suite #3193

Closed
sjmudd opened this issue Sep 18, 2017 · 1 comment
Closed

Comments

@sjmudd
Copy link
Contributor

sjmudd commented Sep 18, 2017

Hi,

In most build trees make is expected to build the binaries taking into account any dependencies whereas make test actually runs any tests of the code.

In Vitess this behaviour is not respected. It's not a big thing but if you want to build the code only you have to type make build rather than just make, and make builds the software but also runs the local test suite.

I would therefore suggest that for consistency with other software build processes the default make target make only builds the source and make test runs the test suite.

If you want to provide a hint for people (this is good as I've been bitten by issues in the past with failed tests) to run the tests then after completing the build step adding a hint to do the build might be appropriate. I guess something along the lines of:

whatever_make_target_this_is:
     ...
     echo "Build completed successfully. Please ensure all tests work by running `make test` as failing to do so may lead you to spending more time diagnosing any issues."
@michael-berlin
Copy link
Contributor

Good point. I've created #3199 to fix it.

I did not add a message to the "build" target though because "make test" is already mentioned in our docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants