Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: reduce topo calls in tabletgateway's WaitForTablets(...) #15373

Closed
timvaillancourt opened this issue Feb 27, 2024 · 0 comments · Fixed by #15347
Closed

Feature Request: reduce topo calls in tabletgateway's WaitForTablets(...) #15373

timvaillancourt opened this issue Feb 27, 2024 · 0 comments · Fixed by #15347
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Feature

Comments

@timvaillancourt
Copy link
Contributor

Feature Description

This issue discusses reducing topo calls in tabletgateway's WaitForTablets(...) when --keyspaces_to_watch is provided

Today, the .WaitForTablets(...) func calls srvtopo.FindAllTargets(...) (from go/vt/srvtopo) that has no option to filter by keyspace, so it does fetches for every available keyspace. Later the targets that don't match --keyspaces_to_watch are nil-ed out in go/vt/discovery

The improvement proposed is to not-fetch keyspaces we don't need when --keyspaces_to_watch. This would happen earlier by passing the expected keyspaces to srvtopo.FindAllTargets(...) and supporting a fallback when no --keyspaces_to_watch is defined

Use Case(s)

Deployments of vtgate with --keyspaces_to_watch defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Triage This issue needs to be correctly labelled and triaged Type: Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant