Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: add more visibility/stats in Tablet Throttler #15223

Closed
shlomi-noach opened this issue Feb 14, 2024 · 0 comments · Fixed by #15224
Closed

Feature Request: add more visibility/stats in Tablet Throttler #15223

shlomi-noach opened this issue Feb 14, 2024 · 0 comments · Fixed by #15224

Comments

@shlomi-noach
Copy link
Contributor

Feature Description

The table throttler exposes some useful stats/metrics today, such as:

  • Number of checks made
  • Check errors
  • Probes latency
  • etc.

Combined with "HeartbeatWrites" stats we can get a picture of throttler state.

However, for more fine grained analysis, and especially where --heartbeat_on_demand_duration is used, we also want to know:

  • When a tablet throttler was "recently checked"
  • When a PRIMARY tablet throttler identifies that shard/replica tables have been "recently checked" (via CheckThrottlerResponse)
  • When the throttler actively requests heartbeat lease.

See #13195 which introduced the RecentlyChecked indicator.

Use Case(s)

Analyzing table throttler behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant