Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL: 'cancelled' migration does not update completed_timestamp, leading to uncollected garbage #13927

Closed
shlomi-noach opened this issue Sep 6, 2023 · 0 comments · Fixed by #13928
Closed

Online DDL: 'cancelled' migration does not update completed_timestamp, leading to uncollected garbage #13927

shlomi-noach opened this issue Sep 6, 2023 · 0 comments · Fixed by #13928
Assignees
@shlomi-noach
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug

Comments

@shlomi-noach
Copy link
Contributor

Similarly to #8499, a migration marked as cancelled does not mark completed_timestamp, keeping it as NULL, which leads to the artifact cleanup query not collecting artifact tables for this migration, which means artifacts are not being cleaned up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlomi-noach shlomi-noach

Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

OnlineDDL: fix nil 'completed_timestamp' for cancelled migrations planetscale/vitess
1 participant
@shlomi-noach