You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The addition of the ICU regular expression in #13391 has led to a small but nonetheless significant memory increase in components that don't need the evalengine in the end. This applies to things like vtorc, vttablet etc.
But when the evalengine is loaded, we also end up loading the regular expression ICU data files. If we move to lazy loading these files on actual usage, we save additional memory.
Reproduction Steps
The slices.Insert allocation shown here is coming mostly from the icuregex package.
Binary Version
HEAD
Operating System and Environment details
All
Log Fragments
No response
The text was updated successfully, but these errors were encountered:
Overview of the Issue
The addition of the ICU regular expression in #13391 has led to a small but nonetheless significant memory increase in components that don't need the
evalengine
in the end. This applies to things likevtorc
,vttablet
etc.Those components do end up importing the
evalengine
through long dependency chains and also more directly through utility functions likeToInt64
/ToUint64
(https://github.com/vitessio/vitess/blob/main/go/vt/vtgate/evalengine/api_types.go#L60-L96).But when the
evalengine
is loaded, we also end up loading the regular expression ICU data files. If we move to lazy loading these files on actual usage, we save additional memory.Reproduction Steps
The
slices.Insert
allocation shown here is coming mostly from theicuregex
package.Binary Version
Operating System and Environment details
Log Fragments
No response
The text was updated successfully, but these errors were encountered: