Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch flag definitions to be on pflag instead of flag in package go/vt/vttablet/filelogger #10973

Closed
ajm188 opened this issue Aug 10, 2022 · 0 comments · Fixed by #11274
Closed

Switch flag definitions to be on pflag instead of flag in package go/vt/vttablet/filelogger #10973

ajm188 opened this issue Aug 10, 2022 · 0 comments · Fixed by #11274
Assignees
@rohit-nayak-ps
Labels
Component: CLI Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup

Comments

@ajm188
Copy link
Contributor

ajm188 commented Aug 10, 2022

Part of #10697.

Current flags:

$ git grep -E "\bflag\.[A-Z]" -- go/vt/vttablet/filelogger/*.go
go/vt/vttablet/filelogger/filelogger.go:var logQueriesToFile = flag.String("log_queries_to_file", "", "Enable query logging to the specified file")
@ajm188 ajm188 added Type: Internal Cleanup Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Observability Pull requests that touch tracing/metrics/monitoring Component: CLI labels Aug 10, 2022
@ajm188 ajm188 mentioned this issue Aug 10, 2022
Closed
@rohit-nayak-ps rohit-nayak-ps self-assigned this Sep 20, 2022
@rohit-nayak-ps rohit-nayak-ps mentioned this issue Sep 21, 2022
Merged
3 tasks
@ramsemune ramsemune mentioned this issue Sep 24, 2022
Open
@snyk-bot snyk-bot mentioned this issue Sep 26, 2022
Open
This was referenced Sep 26, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Sep 29, 2022
Open
This was referenced Oct 5, 2022
Open
Open
This was referenced Oct 25, 2022
Open
Open
@ramsemune ramsemune mentioned this issue Nov 4, 2022
Open
@ramsemune ramsemune mentioned this issue Nov 15, 2022
Open
@ramsemune ramsemune mentioned this issue Nov 28, 2022
Open
@ramsemune ramsemune mentioned this issue Dec 25, 2022
Open
@ramsemune ramsemune mentioned this issue Mar 31, 2023
Open
@snyk-bot snyk-bot mentioned this issue May 22, 2023
Open
This was referenced May 22, 2023
Open
Open
This was referenced Jun 20, 2023
Open
Open
Open
@ramsemune ramsemune mentioned this issue Oct 1, 2023
Open
@ramsemune ramsemune mentioned this issue Nov 25, 2023
Open
@ramsemune ramsemune mentioned this issue Dec 19, 2023
Open
@ramsemune ramsemune mentioned this issue Jan 9, 2024
Open
This was referenced Feb 2, 2024
Open
Open
This was referenced Feb 11, 2024
Open
Open
@ramsemune ramsemune mentioned this issue Mar 22, 2024
Open
This was referenced Apr 29, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohit-nayak-ps rohit-nayak-ps

Labels
Component: CLI Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Enhancement Logical improvement (somewhere between a bug and feature) Type: Internal Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cli] Migrate flag to pflag for file/sys logger planetscale/vitess
2 participants
@ajm188 @rohit-nayak-ps