From 33d991d3d1444ecc911b58defbf33610a73a5d34 Mon Sep 17 00:00:00 2001 From: Andrew Mason Date: Tue, 20 Jun 2023 09:07:58 -0400 Subject: [PATCH] no longer trusting IO in CI Signed-off-by: Andrew Mason --- go/viperutil/internal/sync/sync_test.go | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/go/viperutil/internal/sync/sync_test.go b/go/viperutil/internal/sync/sync_test.go index df494c19bae..3070013b6f8 100644 --- a/go/viperutil/internal/sync/sync_test.go +++ b/go/viperutil/internal/sync/sync_test.go @@ -38,7 +38,7 @@ import ( ) func TestPersistConfig(t *testing.T) { - t.Skip("temporarily skipping this to unblock PRs since it's flaky") + // t.Skip("temporarily skipping this to unblock PRs since it's flaky") type config struct { Foo int `json:"foo"` } @@ -156,7 +156,26 @@ func TestWatchConfig(t *testing.T) { return err } - return os.WriteFile(tmp.Name(), data, stat.Mode()) + err = os.WriteFile(tmp.Name(), data, stat.Mode()) + if err != nil { + return err + } + + data, err = os.ReadFile(tmp.Name()) + if err != nil { + return err + } + + var cfg config + if err := json.Unmarshal(data, &cfg); err != nil { + return err + } + + if cfg.A != a || cfg.B != b { + return fmt.Errorf("config did not persist; want %+v got %+v", config{A: a, B: b}, cfg) + } + + return nil } writeRandomConfig := func() error { a, b := rand.Intn(100), rand.Intn(100)