Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the bridge has potential risk for anyone can create new channel and new keeper #18

Open
KarlChristomer opened this issue Jun 21, 2022 · 0 comments · May be fixed by #21
Open

the bridge has potential risk for anyone can create new channel and new keeper #18

KarlChristomer opened this issue Jun 21, 2022 · 0 comments · May be fixed by #21

Comments

@KarlChristomer
Copy link
Collaborator

Describe the bug briefly

reproduce the risk by following steps:

  1. call vite contract function to create a new channel - newChannel()
  2. call contract function to launch a transfer with the new channelId - input()

Information

logs in Relay

[vite->eth] eth channel id not exist. 6 undefined

reproduce another risk by following steps:

  1. call vite contract function to create a new keeper - newKeepers()
  2. call vite contract function to create a new channel with the new keeperId - newChannel()
  3. call contract function to launch a transfer with the new channelId - input()

Tx in blockchain explorer
image
@KarlChristomer KarlChristomer linked a pull request Sep 21, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add ownership && channel status vitelabs/vite-asset-bridge
1 participant
@KarlChristomer