From 4aafa6bc26e6f22fd99c5a4e83c7e9b4bff019f8 Mon Sep 17 00:00:00 2001 From: Alex Palmer Date: Sun, 12 Mar 2023 14:50:39 +0000 Subject: [PATCH] style(create-vite): use quotes for attributes consistently As part of my changes in #12374, I unintentionally removed the quotes for the Vite logos from the vanilla templates, perhaps because the rest of the templates didn't need them. While HTML5 allows no quotes for attribute values if the value doesn't contain a space, keeping a consistent style is important for cognitive load when reading and maintaining. Hence, I've marked this as a style change. While not a functional change in these templates, it could be if someone later changed the import path to contain a space (perhaps after generating a project using the template). --- packages/create-vite/template-vanilla-ts/src/main.ts | 2 +- packages/create-vite/template-vanilla/main.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/create-vite/template-vanilla-ts/src/main.ts b/packages/create-vite/template-vanilla-ts/src/main.ts index 76dbee315d13f3..2f852a7cf8532f 100644 --- a/packages/create-vite/template-vanilla-ts/src/main.ts +++ b/packages/create-vite/template-vanilla-ts/src/main.ts @@ -6,7 +6,7 @@ import { setupCounter } from './counter' document.querySelector('#app')!.innerHTML = `
- + diff --git a/packages/create-vite/template-vanilla/main.js b/packages/create-vite/template-vanilla/main.js index 5e9d9424f21c9a..b400b4e3d91287 100644 --- a/packages/create-vite/template-vanilla/main.js +++ b/packages/create-vite/template-vanilla/main.js @@ -6,7 +6,7 @@ import { setupCounter } from './counter.js' document.querySelector('#app').innerHTML = `
- +