Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when adding a comment after an import in script setup #801

Closed
drgarlic opened this issue Sep 12, 2020 · 1 comment
Closed

Crash when adding a comment after an import in script setup #801

drgarlic opened this issue Sep 12, 2020 · 1 comment

Comments

@drgarlic
Copy link

drgarlic commented Sep 12, 2020

Created an issue on the Vue repo (vuejs/core#2102) they said to post it here:

Version

3.0.0-rc.10

Reproduction link

https://github.com/gawlk/vue-bug-comment-after-import

Steps to reproduce

  1. yarn create vite-app test-comment-crash
  2. yarn && yarn add mediasoup-client
  3. Go to App.vue and add the setup tag to <script>
  4. Lauch the app
  5. Add this import mediasoup from 'mediasoup-client' // remove this comment and it'll work BEFORE import HelloWorld from './components/HelloWorld.vue' otherwise it won't crash, it can't be after the latest import
  6. See that is crashes
  7. Remove the comment and see that it works

What is expected?

To work flawlessly

What is actually happening?

The app crashes because of a comment

@underfin
Copy link
Member

It is a bug for vue-core, I fixed it and please track here vuejs/core#2107

@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants