Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-react): remove querystring from sourcemap filename #5760

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

frandiox
Copy link
Contributor

Description

The variable used in this sourcemaps fix in plugin-react might contain a querystring, in which case it does not work. This PR removes the querystring passed to Babel.

Additional context

In Hydrogen, some React components end in component.client.jsx?no-proxy and it shows the warning sourcemap for xyz points to missing source files just like in #5438 due to this querystring.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92
Copy link
Member

Is this indirect related to #5761 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants