-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): resolve rollupOptions.input
paths
#5601
Conversation
Would it be possible to add a test case to avoid future regressions? |
Done 👍 |
Thanks for doing the refactors in this PR @sibbng 👍🏼 |
You're welcome @patak-js 😉 |
Just a note, a project that I help out with, https://github.com/eirslett/storybook-builder-vite, was using an unresolved |
@sibbng Regarding this change: 3127219#diff-e861d33a288ea61b3aee05203d1c43920c4326d904e3d41b4326adbd30a0127f I can see the intent to preface the virtual module with an id of I wanted to see if this was intentional, or perhaps some unexpected side-effect? The relevant discussion is here: ElMassimo/vite_ruby#156 We're trying to assess how backend systems should be looking for and loading the |
Description
Related unocss/unocss#88
Entry points defined in
rollupOptions.input
passed to rollup without resolving. This causing some path issues in Windows.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).