Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-app): update svelte templates to use named export of vite-… #3760

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Jun 11, 2021

…plugin-svelte

Description

Starting with version 1.0.0-next.11, @sveltejs/vite-plugin-svelte is going to use a named export 'svelte' instead of a default export for the plugin function. This PR is in preparation for that and should be merged after 1.0.0-next.11 has been released

update: [email protected] has been released this PR is ready to be merged

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dominikg dominikg changed the title [DRAFT] fix(create-app): update svelte templates to use named export of vite-… fix(create-app): update svelte templates to use named export of vite-… Jun 11, 2021
@antfu antfu merged commit c69f836 into vitejs:main Jun 11, 2021
@dominikg dominikg deleted the fix/update-vite-plugin-svelte branch June 11, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants