Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-vue): rewrite default after ts compiled #3591

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Conversation

underfin
Copy link
Member

fix: #3542

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes May 30, 2021
@antfu antfu requested a review from haoqunjiang May 30, 2021 06:58
@patak-dev
Copy link
Member

Independently from this PR, should the replacements for the class check logic also update the source map? (i.e. using magic string for scriptCode)

@Shinigami92 Shinigami92 added the p3-minor-bug An edge case that only affects very specific usage (priority) label May 30, 2021
@underfin
Copy link
Member Author

@patak-js i removed class check. The sourcemap shouldn‘t affect for users, becuase only has cloumn changed, if this line has some error, the users also can realize error and fix it.

@patak-dev
Copy link
Member

@underfin the class check can now be safely removed because @vue/compiler-sfc has been updated as indicated in the comment?

@antfu antfu merged commit ea5bafa into main Jun 1, 2021
@antfu antfu deleted the fix-rewrite-default branch June 1, 2021 00:00
ygj6 pushed a commit to ygj6/vite that referenced this pull request Jun 1, 2021
@hmt
Copy link
Contributor

hmt commented Jun 10, 2021

updating from @vitejs/[email protected] to @vitejs/[email protected] throws an error for me:

Uncaught SyntaxError: duplicate export name 'default'

If I had any clue where this came from, I'd post it here but I have no idea how to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The combination of specific statements and comments can cause errors (vite & vite build)
5 participants