-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-vue): rewrite default after ts compiled #3591
Conversation
Independently from this PR, should the replacements for the class check logic also update the source map? (i.e. using magic string for scriptCode) |
Co-authored-by: Shinigami <[email protected]>
@patak-js i removed class check. The sourcemap shouldn‘t affect for users, becuase only has cloumn changed, if this line has some error, the users also can realize error and fix it. |
@underfin the class check can now be safely removed because |
Co-authored-by: Shinigami <[email protected]>
updating from @vitejs/[email protected] to @vitejs/[email protected] throws an error for me:
If I had any clue where this came from, I'd post it here but I have no idea how to reproduce it. |
fix: #3542
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).