-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-app): add template vanilla-ts #2023
Conversation
Hmm, I'm not sure if this is even necessary since it really just needs a |
I tried to use Aside from my mismatched expectations causing a bump in my otherwise smooth Vite onboarding, I think it's worth noting it's not just adding a tsconfig.json (and going and looking up which values I need to paste in), it's also renaming main.js -> main.ts, going into index.html and renaming the src to point at .ts. Sure, all simple and trivial stuff, but I've done that 5 or 6 times today when scaffolding out modules and it's pretty tedious |
agree would've been nice to have! (although it's also great that it works with such minimal changes from vanilla) |
Maybe we can reconsider having this template? We are having a few contributors request this again #2814, #2849 I think not only this could help ppl to get started quickly without doing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also think we should adapt "build": "tsc && vite build"
from #2849
I am going to make changes to this PR directly and push this thing ready for merging. |
Thanks for taking my proposal into the project. Unfortunatly I was somehow not notified about the further discussions, so please excuse me for not taking part in the conversation. |
Not a problem @HenryVogt, thanks for the PR! |
According to the other templates it might be a helpful addition to have a vanilla typescript template aswell.