If a package.json has both "browser" and "module" fields set, vite resolve ignores mainFields order and picks one of them.

[dominikg]

Describe the bug

here these fields are evaluated before the mainFields loop below. Leading to mainFields being ignored if they would be sorted in front of "browser".

vite-plugin-svelte sets a custom "mainFields" list with "svelte" as the first entry to resolve svelte components directly, which should take precedence over both "browser" and "module".

Reproduction

https://github.com/benoitf/svelte-issue-app

Steps to reproduce

see sveltejs/vite-plugin-svelte#813 too

[email protected] does not include "browser" in mainfields,
[email protected] added it.

System Info

linux, vite 5

Used Package Manager

yarn

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[dominikg]

i'll be working on a PR to fix this, moving the code that sits outside the loop into a utility function and calling it inside the loop when the browser condition is being checked (instead of the current continue).