Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): move TypeScript ones up #12057

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

sapphi-red
Copy link
Member

Description

According to The State of JS 2022, TypeScript usage is quite high recently.
https://2022.stateofjs.com/en-US/usage/#js_ts_balance

I think moving TypeScript templates upwards can improve DX slightly.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 14, 2023
@bluwy
Copy link
Member

bluwy commented Feb 14, 2023

Hmm I'm not really sure about this as for people starting out in general, we should probably recommend JS first. This would also interrupt the muscle memory of those using create-vite a lot. I'm voting to keep it as is at the meantime, but curious to hear what others think too

@patak-dev
Copy link
Member

Adding it to the team board to discuss if we don't reach a consensus here. My first reaction is also in line with @bluwy, I think that I would wait a bit more to do this.

On a related note, we're also pointing to the vanilla JS starter on https://vite.new. If we do this change, maybe we should also point that to TS.

@ArnaudBarre
Copy link
Member

+1 for changing the defaults on vite.new & vite.new/framework

@sapphi-red
Copy link
Member Author

sapphi-red commented Feb 15, 2023

I understand it isn't obvious whether this change has more advantages than disadvantages.

If we change this when create-vite is reorganized (if it's going to happen), maybe we can reduce the impact of the change relatively.

Copy link
Member

@ArnaudBarre ArnaudBarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can keep JS first for Svelte if the team think it's better

@patak-dev
Copy link
Member

I think it is better to be consistent for all frameworks.

@bluwy bluwy merged commit 313712d into vitejs:main Apr 7, 2023
@sapphi-red sapphi-red deleted the feat/move-ts-up branch April 20, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants