Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-vite): add final newline for package.json #11906

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix(create-vite): add final newline for package.json #11906

merged 1 commit into from
Feb 13, 2023

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Feb 2, 2023

Description

Add final newline for pacakge.json to keep consistent with other files.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Feb 13, 2023
@bluwy bluwy enabled auto-merge (squash) February 13, 2023 22:07
@bluwy bluwy merged commit e033e49 into vitejs:main Feb 13, 2023
@pd4d10 pd4d10 deleted the patch-2 branch February 14, 2023 03:03
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@pd4d10 @futurGH
fix(create-vite): add final newline for package.json (vitejs#11906)
772f1b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pd4d10 @bluwy