Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(create-vite): align vue template with create-vue #11128

Merged

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 30, 2022

Description

Updated vue templates to align with create-vue.

https://github.com/vuejs/create-vue-templates/tree/542b43b05c8548ba100f6147e89b448de1d574e8/default
https://github.com/vuejs/create-vue-templates/tree/542b43b05c8548ba100f6147e89b448de1d574e8/typescript

close #9136 (declare module '*.vue' is removed)

Additional context

I added @sodatea to co-author as the README text is copied from create-vue. Should I add a license somewhere too?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label Nov 30, 2022
Comment on lines -2 to -3
// This starter template is using Vue 3 <script setup> SFCs
// Check out https://vuejs.org/api/sfc-script-setup.html#script-setup
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this.
This is written in README and <script setup> is released more than a year ago. (2021/08)

Comment on lines -3 to -7
declare module '*.vue' {
import type { DefineComponent } from 'vue'
const component: DefineComponent<{}, {}, any>
export default component
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is handled by typescript-vue-plugin or Volar's take over mode.

@patak-dev patak-dev enabled auto-merge (squash) November 30, 2022 08:22
@patak-dev patak-dev merged commit 1a54e58 into vitejs:main Nov 30, 2022
@sapphi-red sapphi-red deleted the chore/align-vue-template-with-create-vite branch November 30, 2022 10:09
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants