From 5ab336ac9075a55f742179fe5c412e0c4d940668 Mon Sep 17 00:00:00 2001 From: patak Date: Wed, 1 Jun 2022 09:48:34 +0200 Subject: [PATCH] test: guard against ssr-vue hmr in CI flakiness (#8426) --- playground/ssr-vue/__tests__/ssr-vue.spec.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/playground/ssr-vue/__tests__/ssr-vue.spec.ts b/playground/ssr-vue/__tests__/ssr-vue.spec.ts index a70586a5427df5..47dc436b45d72e 100644 --- a/playground/ssr-vue/__tests__/ssr-vue.spec.ts +++ b/playground/ssr-vue/__tests__/ssr-vue.spec.ts @@ -159,7 +159,10 @@ test('hydration', async () => { }) test('hmr', async () => { - await page.goto(url) + // This is test is flaky in Mac CI, but can't be reproduced locally. Wait until + // network idle to avoid the issue. TODO: This may be caused by a bug when + // modifying a file while loading, we should remove this guard + await page.goto(url, { waitUntil: 'networkidle' }) editFile('src/pages/Home.vue', (code) => code.replace('Home', 'changed')) await untilUpdated(() => page.textContent('h1'), 'changed') })