-
-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax problem with cron wal-g command #658
Conversation
Fix syntax issue inside cron file. Plus fix problem with wal-g run, config file now specified in command
attempt to fix tests
@garry-t why not simplify the check for the same as for pgbackrest? if [ $(psql -tAXc 'select pg_is_in_recovery()') = 'f' ]; then wal-g backup-push {{ postgresql_data_dir }} > {{ postgresql_log_dir }}/walg_backup.log 2>&1; fi or [ $(psql -tAXc 'select pg_is_in_recovery()') = 'f' ] && wal-g backup-push {{ postgresql_data_dir }} > {{ postgresql_log_dir }}/walg_backup.log 2>&1 I don't see the need for different approaches. |
I kept solution closer to original. Will check your suggestion. |
review comment fix
fixed assert for wal-g
Debian bookworm I think I should use the full path, like /usr/local/bin/wal-g |
Feel free to suggest a PR. |
Fix syntax issue inside cron file #657
Plus fix problem with wal-g run, config file now specified in command directly.
This is a simplest solution I found. Minimum changes required, but now it works