Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong initial filter selection #327

Closed
bprusinowski opened this issue Feb 3, 2022 · 6 comments · Fixed by #343
Closed

Wrong initial filter selection #327

bprusinowski opened this issue Feb 3, 2022 · 6 comments · Fixed by #343
Labels
bug Something isn't working

Comments

@bprusinowski
Copy link
Collaborator

Description
For at least one dataset, there is a "No data available for this current filter selection" displayed during a chart type selection step; however when going to a next step, the data is correctly fetched.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://test.visualize.admin.ch/en/browse/dataset/https%3A%2F%2Fenergy.ld.admin.ch%2Fsfoe%2Fbfe_ogd56_energieperspektiven2050%2F4?previous=%7B%22includeDrafts%22%3Afalse%7D.
  2. Click on "Create visualization".
  3. Wait for the error to appear.
  4. Click "Next".
  5. See the data being loaded.

Expected Behavior
The data should be loaded in a first step in way it does in the second step.

Environment

  • Visualize: TEST v3.2.7 (d1d94f5)
  • Browser: Safari 14.1.1 (16611.2.7.1.4)
@bprusinowski bprusinowski added the bug Something isn't working label Feb 3, 2022
@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 4, 2022

I think that would be a nice improvement to include in the sprint. It is related to #328

@sosiology
Copy link
Contributor

@ptbrowne the data is shown as expected during chart type selection but selecting the pie chart or scatter plot leads to an application error
image

@AnninaWalker
Copy link
Contributor

Yes, same issue here!

@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 18, 2022

Should be OK now :) Fixed in 6175627

@AnninaWalker
Copy link
Contributor

👍

@MichelaBurzio
Copy link

👍 ok from me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants