Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Restricted Toggle to single Charts only #1826

Merged
merged 2 commits into from
Nov 12, 2024
Merged

feat: Restricted Toggle to single Charts only #1826

merged 2 commits into from
Nov 12, 2024

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Nov 11, 2024 •
edited
Loading

This PR:

How to test

  1. Go to this Link
  2. Create a Visualization
  3. Publish a Single Chart, See how "remove border toggle" is available ✅
  4. Publish multiple Charts, See how "remove border toggle" is no available ✅

CC: @KerstinFaye

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 9:13am

@noahonyejese noahonyejese removed the request for review from ptbrowne November 11, 2024 09:04
bprusinowski
bprusinowski approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one potential improvement 🚀

app/components/publish-actions.tsx Outdated Show resolved Hide resolved
@noahonyejese noahonyejese merged commit b350345 into main Nov 12, 2024
5 of 7 checks passed
@noahonyejese noahonyejese deleted the feat/border-embed-layouts branch November 12, 2024 09:21
@KerstinFaye
Copy link

Thanks @noahonyejese. Looks good to me!

@bprusinowski bprusinowski mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski bprusinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✓ Add Option to remove border for embedded charts
3 participants
@noahonyejese @KerstinFaye @bprusinowski