-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/homepage add ons #1822
Feat/homepage add ons #1822
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noahonyejese 🚀
There are a few things that could be improved, but overall a nice job 👍
Maybe with the environmental variables, as this seems to not be related to an environment, but rather to "application deployment context", a config file would mean less overhead to add variables and let Abraxas know about them (and we simply would need a single place to update all of them, directly in the repository). Let me know what you think :)
@noahonyejese @KerstinFaye the design has been approved by the client. They asked if it could be made smaller, or reduced to one line, but as this is a temporary solution (until we redesign the landing page), I would propose we keep it as is for now to keep the effort low and within our estimates. My final feedback below:
|
One more thing: In the newsletter copy there is an error in english @noahonyejese Is: Stay up to day and subscribe to our newsletter by adding your email address below. |
Alright thanks also passed it down to @KerstinFaye so that the design side is aligned. |
@sosiology , @KerstinFaye , @adintegra In the future it might be valuable to sync on such large text content piece's, w/ all relevant parties before considering implementation. Changing long Content for a static page, is fairly time consuming especially when there is like 6-8 revisions - resulting in 6 - 8 commits. I will try to mention this early during a sync. So that we can verify all parties agree on something before implementation. 👍 |
This PR resolves #1808 ,resolves #1827 and #1828
What Still needs to be Improved
How to Test
mailto
tab opens w/ the recipient being BAFU ✅Next Steps (for 1808 & 1802)
What will be included in the next PR
CC: @KerstinFaye , @sosiology