Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/homepage add ons #1822

Merged
merged 13 commits into from
Nov 13, 2024
Merged

Feat/homepage add ons #1822

merged 13 commits into from
Nov 13, 2024

Conversation

noahonyejese
Copy link
Contributor

@noahonyejese noahonyejese commented Nov 8, 2024

This PR resolves #1808 ,resolves #1827 and #1828

  • Introduces a Section for Newsletter subscriptions
  • Introduces a Section for Bug Reports
  • Introduces a Section for Feature Requests
  • Allows Bug Reports and Feature Requests on several pages

What Still needs to be Improved

  • The design can be improved for the Bug Report
  • The design for the Newsletter can not be implemented just yet because it would look weird due to the fact the entire landing page still follows the old design.

How to Test

  1. Go to this Link
  2. Scroll to the bottom of the page
  3. See how the Design from @KerstinFaye is implemented ✅
  4. Click on subscribe or Report a bug See how a mailto tab opens w/ the recipient being BAFU ✅

Next Steps (for 1808 & 1802)

  1. Add the selected ixt email
  2. Add preferred body based on language
  3. Add preferred subject

What will be included in the next PR

  • Feedback button for Users and non Users in the header

CC: @KerstinFaye , @sosiology

Copy link

vercel bot commented Nov 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 5:06am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @noahonyejese 🚀

There are a few things that could be improved, but overall a nice job 👍

Maybe with the environmental variables, as this seems to not be related to an environment, but rather to "application deployment context", a config file would mean less overhead to add variables and let Abraxas know about them (and we simply would need a single place to update all of them, directly in the repository). Let me know what you think :)

app/docs/homepage.docs.mdx Outdated Show resolved Hide resolved
app/docs/homepage.docs.mdx Show resolved Hide resolved
app/docs/homepage.docs.mdx Show resolved Hide resolved
app/docs/homepage.stories.tsx Show resolved Hide resolved
app/homepage/bug-report.tsx Show resolved Hide resolved
app/static-pages/en/index.mdx Outdated Show resolved Hide resolved
app/static-pages/en/index.mdx Outdated Show resolved Hide resolved
app/templates/email/bug-report.ts Outdated Show resolved Hide resolved
app/templates/email/bug-report.ts Outdated Show resolved Hide resolved
app/docs/homepage.stories.tsx Outdated Show resolved Hide resolved
@sosiology
Copy link
Contributor

@noahonyejese @KerstinFaye the design has been approved by the client. They asked if it could be made smaller, or reduced to one line, but as this is a temporary solution (until we redesign the landing page), I would propose we keep it as is for now to keep the effort low and within our estimates.

My final feedback below:

  • Newsletter Call to action text
    -Currently we have "Bleiben Sie auf dem Laufenden und abonnieren Sie unseren Newsletter, indem Sie Ihre E-Mail-Adresse unten hinzufügen."
    • I think this is a bit confusing, as the user doesn't enter there email address into a field. I would propose:
      • "Bleiben Sie auf dem Laufenden und abonnieren Sie unseren Newsletter"
      • @KerstinFaye would that work from a UI Copy Perspective?
  • Newsletter Button
    • Clicking on "Abonnieren" currently leads to a 404 error -> @noahonyejese i assume this is still a WIP?
  • Feature Request
    • In the email body, remove the "Umgebung" part - imo this is not relevant when requesting a new feature.
    • Please add a title similar to how you have it for the bug report use "Neue Funktion" or something similar (see screenshot as well)
    • The subject in the email is "Bug Report" please change to "Visualize Feature Request" (see screenshot)
  • Bug Report
    • in the email please change the subject to "Visualize Bug Report" this will help us triage the emails that come to [email protected] accordingly (see screenshot)

image

@sosiology
Copy link
Contributor

One more thing: In the newsletter copy there is an error in english @noahonyejese

Is: Stay up to day and subscribe to our newsletter by adding your email address below.
Expected: Stay up to date and subscribe to our newsletter by adding your email address below.

@noahonyejese
Copy link
Contributor Author

Alright thanks also passed it down to @KerstinFaye so that the design side is aligned.

@noahonyejese
Copy link
Contributor Author

noahonyejese commented Nov 13, 2024

@sosiology , @KerstinFaye , @adintegra In the future it might be valuable to sync on such large text content piece's, w/ all relevant parties before considering implementation.

Changing long Content for a static page, is fairly time consuming especially when there is like 6-8 revisions - resulting in 6 - 8 commits. I will try to mention this early during a sync. So that we can verify all parties agree on something before implementation. 👍

@noahonyejese noahonyejese merged commit 8d0bdff into main Nov 13, 2024
3 of 4 checks passed
@noahonyejese noahonyejese deleted the feat/homepage-add-ons branch November 13, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design: Request New Funtionality Button ✓✓ Newsletter Signup Button
3 participants