diff --git a/CHANGELOG.md b/CHANGELOG.md index 8e87a7512..6d010c758 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ You can also check the layouting step - It's now possible to preview a chart in different sizes before publishing (in the layout step) + - Clicking on a chart title in the user profile now opens the chart - Fixes - Map is now correctly centered after copying a chart or switching to layout mode @@ -39,6 +40,7 @@ You can also check the - Aligned editor and layouting page layouts - Removed dimension selection from modal when merging cubes - Updated styles of confirmation dialog + - Various small style improvements - Maintenance - Updated cube-hierarchy-query library to 3.0.0 diff --git a/app/components/chart-selection-tabs.tsx b/app/components/chart-selection-tabs.tsx index babd96c5a..5b2208ab0 100644 --- a/app/components/chart-selection-tabs.tsx +++ b/app/components/chart-selection-tabs.tsx @@ -3,7 +3,6 @@ import { TabContext } from "@mui/lab"; import { Button, Divider, - Popover, Stack, tabClasses, Theme, @@ -179,18 +178,27 @@ const TabsEditable = (props: TabsEditableProps) => { /> {tabsState.popoverType === "add" ? ( - .MuiList-root": { + py: 0, + }, }, }} > @@ -218,7 +226,7 @@ const TabsEditable = (props: TabsEditableProps) => { showHelp={false} showComparisonCharts={false} chartKey={tabsState.activeChartKey ?? chartConfig.key} - sx={{ width: 320, px: 3, pb: 3 }} + sx={{ pb: 3 }} /> {addNewDatasetFlag ? ( @@ -248,7 +256,7 @@ const TabsEditable = (props: TabsEditableProps) => { ) : null} - + ) : null} {tabsState.popoverType === "edit" ? ( @@ -386,7 +394,15 @@ const useTabsInnerStyles = makeStyles((theme) => ({ }, })); -const TabsInner = (props: { +const TabsInner = ({ + data, + addable, + editable, + draggable, + onChartEdit, + onChartAdd, + onChartSwitch, +}: { data: TabDatum[]; addable: boolean; editable: boolean; @@ -396,15 +412,6 @@ const TabsInner = (props: { onChartSwitch?: (key: string) => void; }) => { const classes = useTabsInnerStyles(); - const { - data, - addable, - editable, - draggable, - onChartEdit, - onChartAdd, - onChartSwitch, - } = props; const [_, dispatch] = useConfiguratorState(hasChartConfigs); const activeTabIndex = data.findIndex((x) => x.active); return ( diff --git a/app/components/menu-action-item.tsx b/app/components/menu-action-item.tsx index 11aa4b513..d96f3388d 100644 --- a/app/components/menu-action-item.tsx +++ b/app/components/menu-action-item.tsx @@ -59,6 +59,7 @@ export const MenuActionItem = ( icon, label, color = "primary", + ...rest }: { icon?: IconName; label: string | NonNullable; @@ -77,17 +78,18 @@ export const MenuActionItem = ( props.type === "button" ? { onClick: handleClick, + ...rest, } : { href: props.href, target: props.target, rel: props.rel, + ...rest, }; if (props.as === "button") { return ( - setAnchorEl(null)} + PaperProps={{ sx: { mt: 3 } }} > { })} onClick={async () => await signOut()} /> - + ) : (