Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Login & UI improvements #1729

Merged
merged 12 commits into from
Sep 9, 2024
Merged

feat: Login & UI improvements #1729

merged 12 commits into from
Sep 9, 2024

Conversation

bprusinowski
Copy link
Collaborator

This PR:

  • updates last edit timestamp to match the design (removed seconds),
  • added tooltip to chart titles in user profile,
  • aligned chart selection popover styles to match the design,
  • fixes hard-refresh when using action menu items,
  • adds an on-click action to chart titles in user profile to open or edit the chart, depending on its publication status.

@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 9:06am

@bprusinowski bprusinowski mentioned this pull request Sep 9, 2024
Closed
@bprusinowski bprusinowski self-assigned this Sep 9, 2024
noahonyejese
noahonyejese approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bprusinowski bprusinowski merged commit adb1144 into main Sep 9, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the feat/small-login-improvements branch September 9, 2024 08:56
@bprusinowski bprusinowski mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahonyejese noahonyejese noahonyejese approved these changes

@KerstinFaye KerstinFaye Awaiting requested review from KerstinFaye

@ptbrowne ptbrowne Awaiting requested review from ptbrowne

Assignees

@bprusinowski bprusinowski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bprusinowski @noahonyejese