-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Server-side eIAM session termination #1727
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@bprusinowski localhost should be whitelisted in eIAM TEST so should be testable. From your description, I'm not 100% sure if this is the configuration you tested against (https://feds-r.eiam.admin.ch/realms/uvek_bafu-visualize/.well-known/openid-configuration)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally the authentication needs to be more easily accessable during dev.
@adintegra I believe so, I used the same env variables that are defined in GitLab that deploys to TEST. Are you able to authenticate successfully from your machine? |
@bprusinowski yes, it's testable. What's critical is this var (which is different from the deployment environment):
Also, ensure you run |
Thanks @adintegra 💯 I'll add this to README, I missed this part 🥲 |
Thanks @bprusinowski! Yes, the documentation on the specifics was a bit sparse – sorry for that. |
No problem @adintegra! In fact, we already had the |
Fixes #1691
This PR fires a request to eIAM servers when user signs out, to also terminate the session on their side.
As we can't connect to eIAM infrastructure from localhost, I wasn't able to test out if this works – we would be able to do so when the change is deployed to TEST.
It would be extremely helpful to be able to connect to e.g. TEST eIAM auth server to work on such issues. @adintegra @ptbrowne do you know if we have such access, maybe I missed this? If not, could we potentially request it?