Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editor & chart tabs UI improvements #1702

Merged
merged 12 commits into from
Sep 2, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Sep 2, 2024

This PR:

  • fixes ghost top rectangle in the homepage example charts,
  • aligns editor and layouting page layouts,
  • improves chart tabs scroll behavior,
  • adds some Accent improvements.

Also see the Figma file.

How to test

  1. Go to this link.
  2. Add a new chart.
  3. Go to layouting step.
  4. ✅ See that the general page layouts are aligned between both steps.
  5. Go back to the editing mode.
  6. Add more charts until they no longer fit on the screen (or resize browser window to achieve the same effect).
  7. ✅ See that scroll buttons appeared and can be used to horizontally scroll the tabs.

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 3:29pm

Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, like this it should be clear how to set up accent in the future, you could add the cmd for temporary add, but it's not necessary since you added .env to .gitignore this is optional. 👍

ACCENT_API_KEY=-YOUR_ACCENT_KEY yarn run locales:pull

Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@bprusinowski
Copy link
Collaborator Author

Yup, good point – I added the inline version to README 👍

@bprusinowski bprusinowski merged commit 99eb19f into main Sep 2, 2024
3 of 4 checks passed
@bprusinowski bprusinowski deleted the feat/dashboard-improvements-2 branch September 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants