Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix varnish cache priming #1685

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Fix varnish cache priming #1685

merged 2 commits into from
Aug 13, 2024

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Aug 13, 2024

I would get "Page has been closed error". I refactored to use a promise pool and a fixed number of pages. It seems to work better now.

I wrongly pushed directly to main to be able to run the job (now I see that I can run a workflow on a particular branch), so if you want to see the diff you can check 4abef98...4c94338

Fixes #1683

@ptbrowne ptbrowne requested a review from bprusinowski as a code owner August 13, 2024 14:42
Copy link

vercel bot commented Aug 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 2:42pm

@ptbrowne
Copy link
Collaborator Author

I am merging since the job is working now.

@ptbrowne ptbrowne merged commit b68f19c into main Aug 13, 2024
3 of 5 checks passed
@ptbrowne ptbrowne deleted the feat/varnish branch August 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly job fails to preload the cache
1 participant