Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize termsets fetching #1633

Merged
merged 10 commits into from
Aug 28, 2024
Merged

perf: Optimize termsets fetching #1633

merged 10 commits into from
Aug 28, 2024

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jun 21, 2024

Closes #1606

This PR optimizes fetching of termsets in every query, in some cases using the new triples (see https://gitlab.ldbar.ch/bafu/visualize/-/issues/684 and https://s.zazuko.com/h7ZwER). Significant performance benefits should be visible on the search page and when looking for mergable cubes.

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 10:02am

@Rdataflow
Copy link
Contributor

the new triples will land on PROD once https://gitlab.ldbar.ch/pipelines/lindas-metadata/-/merge_requests/147 lands in master ...

...it looks like using VALUES is making the query much slower. As here we always only use one cube iri, we can specify it directly and speed up things significantly.
Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@bprusinowski bprusinowski merged commit 4161581 into main Aug 28, 2024
5 of 6 checks passed
@bprusinowski bprusinowski deleted the feat/new-termset-triples branch August 28, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✅ Integration of new triples on TEST
3 participants