Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map zoom + and - buttons not working #932

Closed
FabianCretton opened this issue Jan 16, 2023 · 8 comments
Closed

Map zoom + and - buttons not working #932

FabianCretton opened this issue Jan 16, 2023 · 8 comments
Labels
bug Something isn't working to reproduce

Comments

@FabianCretton
Copy link

Describe the bug
I tried a map representation on this dataset:
https://int.visualize.admin.ch/en/create/Bi1ZypL-QY9F?dataSource=Int

and the + and - zoom buttons have no effect. The mouse wheel does work though

Screenshots or video
image

Environment (please complete the following information):

  • Visualize environment and version: INT v3.18.0 ([91ae9f5]
  • Browser and version: Firefox 108.0.2
@FabianCretton FabianCretton added the bug Something isn't working label Jan 16, 2023
@sosiology
Copy link
Contributor

Additional Information:
I tested the reported bug in the following browsers with the dataset fab_UBD010703_03 MFM-U Luftdaten Jahresmittel (Russ)on INT and could not reproduce the error.

  • Chrome Version 108.0.5359.124 (Official Build) (arm64)
  • Firefox Version 108.0.2 (64-bit)
  • Firefox Version 108 on Windows via Browserstack

@FabianCretton
Copy link
Author

Thank you for having a look.
On my Windows laptop, the +/- buttons do not react to a mouse click.
I tried with Firefox 108.0.2 (64 bit) and Edge 109.0.1518.52
On another computer, Windows as Well, it DOES WORK with my firefox 107.0 (64-bit)

Let see if other people experience this...

@ptbrowne
Copy link
Collaborator

@FabianCretton This could be due to another transparent element stealing the click. Would be interesting if you have time to right click and do "Inspect Element". Then to screenshot the console tab of the inspector. This should hopefully tell us which element is "above".

@FabianCretton
Copy link
Author

Here is the right-click/Inspect on the + button:
image

But do you mean that you can not reproduce it ?

@ptbrowne
Copy link
Collaborator

Yes unfortunately I am not able to reproduce it.

@ptbrowne
Copy link
Collaborator

ptbrowne commented Mar 2, 2023

@Rdataflow or @ortnever are you reproducing ?

@FabianCretton
Copy link
Author

on my side, I still have this same issue. was my debug printscreen of any use ?

@ptbrowne
Copy link
Collaborator

ptbrowne commented Mar 3, 2023

I had a second look, and could find the reason. It is due to a setting that you have on your work machine that controls whether animations should be played (I guess that on government machines that are meant to be accessed remotely, animations are deactivated by default). The method we used to zoom in would use an animation and the framework would respect the setting of disabling animation, resulting in no animation, thus no zooming.
Now we say to the map to force the zoom since the animation is essential, and not cosmetic.

Thanks for the screenshot, it helped understand that the button was indeed working, but it was after that something was not working. It should be deployed promptly in int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working to reproduce
Projects
None yet
Development

No branches or pull requests

3 participants