Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata panel – enhancements #917

Closed
4 tasks
bprusinowski opened this issue Nov 29, 2022 · 2 comments · Fixed by #922 or #927
Closed
4 tasks

Metadata panel – enhancements #917

bprusinowski opened this issue Nov 29, 2022 · 2 comments · Fixed by #922 or #927
Assignees
Labels
enhancement New feature or request

Comments

@bprusinowski
Copy link
Collaborator

bprusinowski commented Nov 29, 2022

  • Add fetching of dimension's values descriptions
  • Fix focus issue on the homepage, when a panel is open in the first chart, and the user tries to open another panel in the second chart
  • Add links to open metadata panel from the tables (but keep them for dataset preview table)
  • Add E2E tests
@sosiology
Copy link
Contributor

  • Remove Icons
  • Add "Show more" link to each item

@AnninaWalker
Copy link
Contributor

Hey @bprusinowski Please find below my feedback in the screenshots. It's mainly design adjustments.

In general the metadata should be structured via the Textstyling. I think we could get rid of those grey lines and instead style the text as title and main text. Currently its a bit of a mix. See screenshots.

I'd also reintroduce the underline to make it more clear that metadata is hidden under some labels. Can we influence here the spacing between the underline and the text? The standard one I find a bit too narrow.

We could also try - instead of using the Textlink for the "Metadata" Label - to use a Secondary Contained Button to make the Metadata more visible.

I couldn't test the Metadata Panel in the published version as it always crashes.

Screenshot 2022-12-06 at 09 28 03

Screenshot 2022-12-06 at 09 30 59

Screenshot 2022-12-06 at 09 34 40

Screenshot 2022-12-06 at 09 37 05

Screenshot 2022-12-06 at 09 39 52

Screenshot 2022-12-06 at 09 41 45

Screenshot 2022-12-06 at 09 44 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants