Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show link to further information "dcat:landingpage" on final graphic #599

Closed
sosiology opened this issue Jul 21, 2022 · 6 comments
Closed

Show link to further information "dcat:landingpage" on final graphic #599

sosiology opened this issue Jul 21, 2022 · 6 comments
Assignees
@ptbrowne
Labels
development enhancement New feature or request

Comments

@sosiology
Copy link
Contributor

sosiology commented Jul 21, 2022 •
edited
Loading

https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/351
@ptbrowne ptbrowne self-assigned this Aug 17, 2022
@ptbrowne
Copy link
Collaborator

Closed with #607

@AnninaWalker
Copy link
Contributor

AnninaWalker commented Aug 23, 2022 •
edited
Loading

@ptbrowne According to the feedback in GitHub this link should only be shown in the published graphic, but I guess it is ok, to show it all the time. Please change style and size according to general component with link and Icon (see screenshot).
I'd also change the naming. Something like "more information about the data" I'm sure @sosiology has a better suggestion.

Image

@ptbrowne
Copy link
Collaborator

ptbrowne commented Aug 23, 2022 •
edited
Loading

According to the feedback in GitHub this link should only be shown in the published graphic, but I guess it is ok, to show it all the time.

For now, this is the same component that is used in the editor and in the published view. As I understood, the initial rationale was to show the user in the editor always what was going to be published.

Concerning the styling, something like this ?

image

@AnninaWalker
Copy link
Contributor

Yes, I would only change the order and have probably: Download, Switch to Table view, Learn more.. and then the RUN SPARQL. Or the learn more about the dataset at the very end

@sosiology
Copy link
Contributor Author

Wording LGTM! thanks @AnninaWalker and @ptbrowne

@ptbrowne ptbrowne reopened this Aug 25, 2022
@ptbrowne ptbrowne mentioned this issue Aug 25, 2022
Merged
@ptbrowne
Copy link
Collaborator

Fixed in #662

@ptbrowne ptbrowne added the enhancement New feature or request label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptbrowne ptbrowne

Labels
development enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ptbrowne @sosiology @AnninaWalker