Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters are removed when a filter is changed and there is no data for the configuration #385

Closed
sosiology opened this issue Feb 18, 2022 · 1 comment · Fixed by #384
Closed
Assignees
Labels
bug Something isn't working

Comments

@sosiology
Copy link
Contributor

Describe the bug
The default filters ensure that data is loaded and a visualization is shown. However if the filters are changed, and there is no data for a specific configuration, the filters are removed. This is confusing because it is unclear if the error is caused by the application or the user.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://int.visualize.admin.ch/en/browse/dataset/https%3A%2F%2Fculture.ld.admin.ch%2Fsfa%2FStateAccounts_Category%2F5%2F?previous=%7B%22includeDrafts%22%3Afalse%2C%22order%22%3A%22SCORE%22%2C%22search%22%3A%22peaks%22%7D
  2. Click on 'Start a visualization" -> Select areas chart type and then "next"
  3. in the left sidebar change the filter from "Allgemeine Verwaltung" to "Ertrag der Liegenschaften und Kapitalien"
  4. All filters are removed from the left side bar and the user has to add them again.

Expected behavior
In this case I would expect to see an error message informing me that no data for the selected filter configuration is available

Screenshots
https://user-images.githubusercontent.com/29289679/154710882-b456f96d-95e9-4f60-a08c-ec11a4e760d5.mov

Environment (please complete the following information):

  • Visualize environment and version: INT
  • Browser and version Firefox, Edge

Additional context
Add any other context about the problem here.

@sosiology
Copy link
Contributor Author

Reviewed on TEST and works as expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants