Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map labelling is covered by shapes #370

Closed
AnninaWalker opened this issue Feb 17, 2022 · 5 comments · Fixed by #379
Closed

Map labelling is covered by shapes #370

AnninaWalker opened this issue Feb 17, 2022 · 5 comments · Fixed by #379
Assignees
Labels
bug Something isn't working

Comments

@AnninaWalker
Copy link
Contributor

Describe the bug
The shapes of the maps cover the labelling

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://test.visualize.admin.ch/en/v/jJzFiZoMCADv
  2. See error

Expected behavior
Labels should be on top

Screenshots
Screenshot 2022-02-17 at 18 01 37

@AnninaWalker AnninaWalker added the bug Something isn't working label Feb 17, 2022
@Rdataflow
Copy link
Contributor

@AnninaWalker do we want to display those labels at all for the purpose of base map? IHMO it just drains the users focus from the statistical map (at least with the current opaque font styling)

@bprusinowski would it be a big step to switch to the global endpoint? - (see yesterdays comm with swisstopo)

@bprusinowski
Copy link
Collaborator

When it comes to the labels, the decision is up to us – it will be really simple to completely disable them, having them displayed on the shapes will require more work.

I think it shouldn't be a big change to switch to the global endpoint – we would probably need to coordinate with Abraxas team to hide the endpoint from our repository, we did investigate this a bit today with @ptbrowne.

@AnninaWalker
Copy link
Contributor Author

I would honestly disable the labels as it looks very distracting. Especially in this case, when some cantons are deselected
Screenshot 2022-02-17 at 18 32 14

154533819-bac187b3-6750-4690-af52-f06c58b4c976

@ptbrowne ptbrowne self-assigned this Feb 18, 2022
@sosiology
Copy link
Contributor

Reviewed on TEST and LGTM! Thanks @ptbrowne

@MichelaBurzio
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants