Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (i) Icon that appears when editing / creating map visualizations #360

Closed
sosiology opened this issue Feb 17, 2022 · 5 comments · Fixed by #361
Closed

Remove (i) Icon that appears when editing / creating map visualizations #360

sosiology opened this issue Feb 17, 2022 · 5 comments · Fixed by #361
Assignees
Labels
bug Something isn't working

Comments

@sosiology
Copy link
Contributor

sosiology commented Feb 17, 2022

Describe the bug
When creating visualizations with the chart type: maps, an unexpected (i) icon appears in the bottom right-hand corner below the zoom toggles.

To Reproduce
Steps to reproduce the behavior:

  1. Go to test.visualize.admin.ch
  2. Select "Bathing Water Quality Dataset"
  3. Select Chart Type: Map
  4. While editing the map an unexpected (i) icon appears in the bottom right-hand corner below the zoom toggles
    Screenshot 2022-02-17 at 10 44 56

Expected behavior
The (i) should be removed if no additional information is provided to the user. Alternatively, "Swisstopo" should be shown, analog the published chart. See "Additional Context" below.

Links
Example of a published chart: https://test.visualize.admin.ch/en/v/VWCtv10OBxBz

Environment (please complete the following information):

  • Visualize environment and version: Test v3.3.0
  • Chrome

Additional context
On the published chart the (i) is not there, but rather "Swisstopo" is shown - which I believe is correct as they are the source of the information / data. However, I find the black arrow to be confusing. Maybe we can remove it?
Screenshot 2022-02-17 at 11 24 16

@sosiology sosiology added the bug Something isn't working label Feb 17, 2022
@bprusinowski bprusinowski mentioned this issue Feb 17, 2022
2 tasks
@AnninaWalker
Copy link
Contributor

I still see the weird black arrow on top of the swisstopo logo

@ptbrowne
Copy link
Collaborator

It's going to be fixed when #361 is merged (really soon).

@bprusinowski
Copy link
Collaborator

I am just waiting for the pipelines go finish 😅 It will be available on TEST in ~ 15 mins.

@AnninaWalker
Copy link
Contributor

AnninaWalker commented Feb 17, 2022

Now everything disappeared, the arrow and the ©swisstopo. I don't know if the swisstopo copywright needs to be shown? If not it is ok for me as it is now

@bprusinowski
Copy link
Collaborator

It was disabled temporarily, we have #369 to deal with this properly. It turned out to be challenging to make it display correctly, without this weird black arrow on top and with actual interactions (so you could click on swisstopo – it's actually a link – and hover over the info icon when on mobile).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants