Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of rdf:langString data types when querying observations #319

Closed
ortnever opened this issue Feb 3, 2022 · 7 comments
Closed

Support of rdf:langString data types when querying observations #319

ortnever opened this issue Feb 3, 2022 · 7 comments
Labels
enhancement New feature or request

Comments

@ortnever
Copy link

ortnever commented Feb 3, 2022

No value appears in the Filter "Schadstoffe" of the Dataset "MFM-U Luftdaten Jahresmittel NOx"

  1. Open test.visualize and navigate in German
  2. search MFM-U, include Draft
  3. Select the data set "MFM-U Luftdaten Jahresmittel NOx"
  4. Create a bar chart visualization
  5. Next -> the filter of dimension "Luftschadstoffe" is empty, while in the middle it's written "Messstation: Camignolo, Luftschadstoff: NOx".

image

Environment (please complete the following information):

Visualize environment : v3.2.7 [https://github.com/visualize-admin/visualization-tool/commit/ce02c26680448b1b7c4f4e8ca1b171484ae9120e]
Browser and version : Edge 97.0.1072.55 (64 bits)

@ortnever ortnever added the bug Something isn't working label Feb 3, 2022
@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 3, 2022

Hi Veronique, I am looking into the issue, the first thing I see is that in the log I have a message "WARNING: Dimension https://environment.ld.admin.ch/foen/UBD010702/station has dataType 'langString'. Filtering won't work.". It is not very clear to me yet, I will continue to look into it, but maybe this has something to do with the cube itself.

@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 3, 2022

I see that we have specific code to log a warning for this specific type of dimension.

619ec5f

@l00mi Do you have more information on why this was added ? What are rdf:langString ? Should the cube be modified to work ?

@ortnever
Copy link
Author

ortnever commented Feb 3, 2022

I removed the language for the Stations and Parameter dimensions, in the Cube UBD10703 MFM-U Luft Russ. It works in test Visualize (choose Version 2).
I left UBD10702 MFM-U Luft NOx as it was, for bug tracking.

image

@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 3, 2022

Thanks Veronique from reporting this issue. I have several remarks

  • From the point of view of visualize.admin, any dataset that used those rdf:langString could not be used I think since we have never been able (from what I see in the code) to use filtering on this kind of dimension, to fetch the observations
  • Considering the display of values in the dropdown, I was able to make it work, but this is not the same story for the observations, that use another query.
  • Thus, I would rename this issue now to "Support rdf:lang columns when querying observations", re-label this issue from “bug” to “enhancement” because at the moment even though rdf:langString works in the cube creator, it is not supported in visualize yet for observations and we would need to implement this in a future sprint if we choose that supporting cubes with rdf:langString columns is important

@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 3, 2022

You can see now that the dropdown values are loaded on test.visualize.admin for the "UBD10702 MFM-U Luft NOx" dataset.

@ortnever
Copy link
Author

ortnever commented Feb 3, 2022

OK. Thanks for the research.
So as long as we enter the String type, without specifying a language in the CC it's ok, right?

@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 3, 2022

Yes :)

@ptbrowne ptbrowne added enhancement New feature or request and removed bug Something isn't working labels Feb 3, 2022
@ptbrowne ptbrowne changed the title No value in Filter Dimension Support of rdf:langString data types when querying observations Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants