Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✓ Development: Image Download Single Chart #1928

Closed
sosiology opened this issue Dec 2, 2024 · 4 comments · Fixed by #1956
Closed

✓ Development: Image Download Single Chart #1928

sosiology opened this issue Dec 2, 2024 · 4 comments · Fixed by #1956
Assignees

Comments

@sosiology
Copy link
Contributor

sosiology commented Dec 2, 2024

Implement the image download for a single chart

Design Task: #1927

@bprusinowski
Copy link
Collaborator

@sosiology @KerstinFaye the feature can be reviewed here: #1931

@KerstinFaye KerstinFaye changed the title Development: Image Download Single Chart ✓ Development: Image Download Single Chart Dec 10, 2024
@sosiology
Copy link
Contributor Author

sosiology commented Jan 8, 2025

@bprusinowski Thanks for this! While testing on TEST i noticed that if the chart image is downloaded from the published page "Created with visualize.admin.ch" appears 2x on the exported image. If the image is downloaded from the editor mode, it only shows up 1x.

Examples

  1. Bar Chart: https://test.visualize.admin.ch/en/v/Md9KZ3H4AipE?dataSource=Prod
    Image

  2. Bar Chart with Standard Error: https://test.visualize.admin.ch/v/KDrVsrnKFJlR?dataSource=Prod
    Image

Screen Recording 2025-01-08 at 11.38.15.mov.zip

@KerstinFaye should we include the option to download the image directly from the user profile in the "actions" menu? Image

@bprusinowski
Copy link
Collaborator

@sosiology thanks for noticing this, I'll take a look! A small note: to make a screenshot we actually have to "see" the chart rendered on a page, which would make it a bit tricky to enable the button here, as we'd need to open the chart preview, make a screenshot and close it (more or less 😅).

@sosiology
Copy link
Contributor Author

@bprusinowski thanks for the explanation - makes sense that the chart needs to be visible to download the image. Due to the technical complexity - I would not include the chat image download in the user profile for now - but maybe something to think about in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants