Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✓ Remove Option to "Remove Border" from tabs and dashboards #1892

Closed
sosiology opened this issue Nov 18, 2024 · 1 comment · Fixed by #1904
Closed

✓ Remove Option to "Remove Border" from tabs and dashboards #1892

sosiology opened this issue Nov 18, 2024 · 1 comment · Fixed by #1904
Assignees

Comments

@sosiology
Copy link
Contributor

When testing on INT the border option to remove the border from an embedded iframe is still available for tabs and dashboards

Steps to Reproduce

  1. Go to https://int.visualize.admin.ch/en/v/CjRciHD7YP7S?dataSource=Prod
  2. See Tab layout
  3. Click the Embedd button
  4. See that the option to remove the border is there for a tab layout
  5. Go to https://int.visualize.admin.ch/en/v/F6FU0bjgBEg0?dataSource=Prod
  6. See Dashboard
  7. Click the Embedd button
  8. See that the option to remove the border is there for a tab layout

Expected Behaviour
The option to remove the border should only be possible for single charts (or single URLs)

Image

Originally posted by @sosiology in #1794

@sosiology
Copy link
Contributor Author

Thanks for the refinement @noahonyejese LGTM 👏

@sosiology sosiology changed the title Remove Option to "Remove Border" from tabs and dashboards ✓Remove Option to "Remove Border" from tabs and dashboards Nov 20, 2024
@sosiology sosiology changed the title ✓Remove Option to "Remove Border" from tabs and dashboards ✓ Remove Option to "Remove Border" from tabs and dashboards Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants