Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Data Selection Overlay cannot be closed if browser window is reduced #1607

Closed
sosiology opened this issue Jun 12, 2024 · 1 comment · Fixed by #1615
Closed

✅ Data Selection Overlay cannot be closed if browser window is reduced #1607

sosiology opened this issue Jun 12, 2024 · 1 comment · Fixed by #1615
Assignees
Labels
bug Something isn't working

Comments

@sosiology
Copy link
Contributor

sosiology commented Jun 12, 2024

Steps to reproduce

  1. Go to test.visualize.admin.ch
  2. Select a data set and proceed to creating a chart
  3. Create a chart, then add another chart with another data set
  4. Once the dataset search overlay appears, Reduce the browser window to ca. 50%
  5. Click the "x" to close the overlay
  6. See that the click target is not quite centred, making it seem like the overlay cannot be closed

Expected Behaviour
When clicking the X i would expect the overlay to close, it seems like the click target is a bit to far to the right.

Screenshots
See: https://www.notion.so/interactivethings/Testing-File-f5fb6a3566374bce9a731bbdf1734761?pvs=4#d508bcaab7c84479b862076c4381e4ec (file upload to github failed, presumably to large)

@sosiology
Copy link
Contributor Author

LGTM 👏

@sosiology sosiology changed the title Data Selection Overlay cannot be closed if browser window is reduced ✅ Data Selection Overlay cannot be closed if browser window is reduced Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants