Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ ✅ Adding Chart from Different Dataset: Concept Filters not working #1534

Closed
sosiology opened this issue May 28, 2024 · 3 comments · Fixed by #1554
Closed

✅ ✅ Adding Chart from Different Dataset: Concept Filters not working #1534

sosiology opened this issue May 28, 2024 · 3 comments · Fixed by #1554
Assignees
Labels
bug Something isn't working

Comments

@sosiology
Copy link
Contributor

Description
When adding a new chart with a new data set, the concept filters in the dataset selection page do not work.

Screen.Recording.2024-05-28.at.16.53.45.mov
@sosiology sosiology added the bug Something isn't working label May 28, 2024
@bprusinowski bprusinowski self-assigned this Jun 4, 2024
@sosiology
Copy link
Contributor Author

Thanks for the fix @bprusinowski - the concept filters are now clickable. I noticed though that the number of data sets shown in the chip, do not correspond to the actual number of data sets shown

Example
For Cantons - it appears i have 37 data sets

Image

but when I select it only 5 are shown

Image

Not sure if i a missing something, if it is in fact a bug, i will open a new issue for it.

@bprusinowski
Copy link
Collaborator

bprusinowski commented Jun 13, 2024

Hi @sosiology, if I remember correctly, we fetch all possible cubes in the Concepts section, but when it comes to filtering, we can't yet catch all the relevant cubes until we integrate new triples due to performance reasons. However I may be wrong, I think it's a good thing to add an issue so it's not forgotten 👍

@sosiology
Copy link
Contributor Author

@bprusinowski thanks for your feedback - we have an issue for integrating the new triples here #1606 i will add a note in that issue so we don't forget to retest this once it is completed.

@sosiology sosiology changed the title Adding Chart from Different Dataset: Concept Filters not working ✅ Adding Chart from Different Dataset: Concept Filters not working Jun 13, 2024
@KerstinFaye KerstinFaye changed the title ✅ Adding Chart from Different Dataset: Concept Filters not working ✅ ✅ Adding Chart from Different Dataset: Concept Filters not working Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants