Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying a link to new visualization from dataset preview lacks current data source #1289

Closed
bprusinowski opened this issue Dec 4, 2023 · 1 comment · Fixed by #1290
Closed
Assignees
Labels
bug Something isn't working

Comments

@bprusinowski
Copy link
Collaborator

bprusinowski commented Dec 4, 2023

Currently, when copying a link to a new visualization from a given dataset preview, we do not include the data source, which can lead to potential errors if the person receiving the link has a different data source than the person sharing the link.

Screenshot 2023-12-04 at 16 26 33

Link copied from Start a new visualization button (TEST): https://test.visualize.admin.ch/en/create/new?cube=https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/9

Corrected link: https://test.visualize.admin.ch/en/create/new?cube=https://energy.ld.admin.ch/sfoe/bfe_ogd84_einmalverguetung_fuer_photovoltaikanlagen/9&dataSource=Prod

@bprusinowski bprusinowski added the bug Something isn't working label Dec 4, 2023
@bprusinowski bprusinowski self-assigned this Dec 4, 2023
@sosiology
Copy link
Contributor

Tested with the example in the PR and LGTM. Thanks @bprusinowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants