From 64c4d7af4cdd398eea56fcd983b5b76e65971771 Mon Sep 17 00:00:00 2001 From: Bartosz Prusinowski Date: Wed, 6 Nov 2024 10:56:09 +0100 Subject: [PATCH] feat: Remove shared dashboard filters flag --- CHANGELOG.md | 3 ++- app/configurator/components/layout-configurator.tsx | 4 +--- app/flags/flag.tsx | 1 - app/flags/types.ts | 2 -- 4 files changed, 3 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0e809526e..6ac046308 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,7 +11,8 @@ You can also check the # Unreleased -Nothing yet. +- Features + - Removed a flag for shared dashboard filters # [4.9.3] - 2024-10-29 diff --git a/app/configurator/components/layout-configurator.tsx b/app/configurator/components/layout-configurator.tsx index 61a55caa5..1365bf6c7 100644 --- a/app/configurator/components/layout-configurator.tsx +++ b/app/configurator/components/layout-configurator.tsx @@ -52,7 +52,6 @@ import { TemporalDimension, TemporalEntityDimension, } from "@/domain/data"; -import { useFlag } from "@/flags"; import { useTimeFormatLocale, useTimeFormatUnit } from "@/formatters"; import { useConfigsCubeComponents } from "@/graphql/hooks"; import { useLocale } from "@/src"; @@ -60,12 +59,11 @@ import { useDashboardInteractiveFilters } from "@/stores/interactive-filters"; import { getTimeFilterOptions } from "@/utils/time-filter-options"; export const LayoutConfigurator = () => { - const sharedFiltersFlag = useFlag("layouter.dashboard.shared-filters"); return ( <> - {sharedFiltersFlag ? : null} + ); }; diff --git a/app/flags/flag.tsx b/app/flags/flag.tsx index 34cc62c2a..622a59d82 100644 --- a/app/flags/flag.tsx +++ b/app/flags/flag.tsx @@ -92,7 +92,6 @@ const initFromHost = (host: string) => { isVercelPreviewHost(host) ) { setDefaultFlag("configurator.add-dataset.shared", true); - setDefaultFlag("layouter.dashboard.shared-filters", true); } }; diff --git a/app/flags/types.ts b/app/flags/types.ts index 26fbf9f11..294c52a4b 100644 --- a/app/flags/types.ts +++ b/app/flags/types.ts @@ -5,8 +5,6 @@ export type FlagName = | "debug" /** Whether we can add dataset from shared dimensions */ | "configurator.add-dataset.shared" - /** Whether we can use shared filters on dashboard layout */ - | "layouter.dashboard.shared-filters" /** Whether server side cache is disabled */ | "server-side-cache.disable" /** The GraphQL endpoint, is used for testing purposes */