Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller - Multiple Fixes #29

Open
adrian-moisa opened this issue May 21, 2022 · 0 comments
Open

Controller - Multiple Fixes #29

adrian-moisa opened this issue May 21, 2022 · 0 comments
Labels

Comments

@adrian-moisa
Copy link
Collaborator

adrian-moisa commented May 21, 2022

VE Controller - bringIntoView no longer works

Typing text when the cursor is scrolled out of the viewport no longer triggers scroll.

VE Controller - Mac, Ctrl + random keys triggers unexpected behaviours #29

This one is rather odd and annoying. To reproduce it we need to press random keys on the keyboard while pressing the Control meta key. I'd expect nothing to happen when pressing this such a combo. I'm not aware of any expected behaviours in other text editors. And from reading the Flutter Quill code I can say I don't remember seeing this as an intentional feature (Super Editor, Google Docs, Microsoft Word).

Screen.Recording.2022-05-22.at.00.04.26.mov

VE Controller - Can't remove style on paragraphs that are separated by a new line #42

First of all: thank you so much for working on a fork. The original project is super buggy and users are always complaining about the editor so I am more than happy to see progress in this :-)

A bug that always happens is for example:

Write two paragraphs (separated by a new line), select both of them (or just "select all") and apply formatting like "bold" or "italic". Then you are not able to remove the style for both paragraphs. The only way is to select each paragraph separately and then you can press the "bold" button again for example and this feels 😣

Screenshot_20220524-085819

VE Controller - Add custom embed insertion code in the controller from demo page #220

VE Controller - Fix and Demo keepStyleOnNewLine

VE Controller - Cache get plainText PERF

This is a potential place for improvement, Many places call on this method. It should return a cached answer.
TextEditingValue get plainText {

@adrian-moisa adrian-moisa removed the Low label Nov 5, 2022
@adrian-moisa adrian-moisa changed the title [Web] Pressing Control on Mac and random keys triggers random unexpected actions Editor - Mac, Ctrl + random keys triggers unexpected behaviours Nov 6, 2022
@adrian-moisa adrian-moisa removed the 0.2 label Jan 23, 2024
@adrian-moisa adrian-moisa changed the title Editor - Mac, Ctrl + random keys triggers unexpected behaviours Controller - Multiple Fixes Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants