Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar - Multiple Fixes #103

Open
adrian-moisa opened this issue Jul 24, 2022 · 0 comments
Open

Toolbar - Multiple Fixes #103

adrian-moisa opened this issue Jul 24, 2022 · 0 comments
Labels

Comments

@adrian-moisa
Copy link
Collaborator

adrian-moisa commented Jul 24, 2022

VE Toolbar - Text size selector should show the current size #16

This again is standard behaviour in most editors. This feature was adde in Flutter Quill right before I forked it. It wasn't polished and needs more attention to detail. One of the reasons this went trough is because of the lack of automatic testing and higher code review standards. My goals is not to let such half backed features sneak into the code base.

image

VE Toolbar - Headings dropdown after text size #15

Right now the controls are far apart and inconsistent. The convention in editors such as word or g docs is to have a headings dropdown and to offer up to 6 headings.

image

0c4eea42-d9fc-4204-a5cc-d69c8fccd0f2

VE Toolbar - Image upload modal missing bgr color #32

image

VE Toolbar - Config model, Clean build() #103

  • Used the same config object pattern as in editor.
  • Also update the build to use aliases.
  • Update toolbar docs.
  • Update the migration guide.

VE Toolbar - The size of the text does not match the value in dropdown #121

When selecting a range of text the sizes dropdown preselects 11 when in fact the text is 16. After applying a size then the selector seems to be working fine. This is probably happening because when the editor starts adding a new document it does not add the text attribute value. Therefore the dropdown is built to assume 11 as the size. But somehow in the examples it seems 16 is the size. We need to setup a means of querying the default text size and not assume it.

image

VE Toolbar - Wrong pointer over toolbar when text is selected #122

  • When the text is selected the hovering cursor for toolbar is the text selector instead of the pointer cursor. I'd expect the same behaviour from the pointer with or without selected text. Clicking outside of the text area (thus disabling the caret) restores the pointer feature on the toolbar (even if the text selection is still rendered).
  • Same issue is affecting the checkboxes as well. The checkbox has no pointer cursor behaviour or any indication of state being clickable (hovered state).
Screen.Recording.2022-05-22.at.00.12.45.mov

Shows cursor pointer
image

Shows text selector
image

VE Toolbar - White background on all toolbars

VE Toolbar - Refactor buttons, split in smaller parts #216

@adrian-moisa adrian-moisa added MVP and removed Medium labels Nov 5, 2022
@adrian-moisa adrian-moisa changed the title Toolbar - Config model Toolbar - Config model, Clean build() Nov 5, 2022
@adrian-moisa adrian-moisa added R3 Bugs and removed 0.1 labels Jan 23, 2024
@adrian-moisa adrian-moisa changed the title Toolbar - Config model, Clean build() Toolbar - Multiple Fixes Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant