Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visjs-network#45: correctly set invalid labels to undefined #26

Merged
merged 1 commit into from
Jul 27, 2019
Merged

visjs-network#45: correctly set invalid labels to undefined #26

merged 1 commit into from
Jul 27, 2019

Conversation

mojoaxel
Copy link
Member

@mojoaxel mojoaxel commented Jul 26, 2019 •
edited
Loading

This is an original contribution from @channeladam: visjs-community/visjs-network#45

fixes visjs-community/visjs-network#44

part of #7

@yotamberk yotamberk merged commit fd6ffe2 into master Jul 27, 2019
@yotamberk yotamberk deleted the fix-short-circuit-draw-visible-in-labeljs branch July 27, 2019 16:18
@mojoaxel mojoaxel mentioned this pull request Jul 27, 2019
Closed
@mojoaxel mojoaxel added this to the v6 milestone Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yotamberk yotamberk yotamberk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.

Invalid labels are still being considered visible & draw happens unnecessarily for invalid labels
3 participants
@mojoaxel @yotamberk @channeladam